Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix centered dashboard listing #21119

Merged
merged 1 commit into from
Jul 24, 2018
Merged

Fix centered dashboard listing #21119

merged 1 commit into from
Jul 24, 2018

Conversation

snide
Copy link
Contributor

@snide snide commented Jul 23, 2018

We likely won't get [email protected] in to Kibana, so this fixes dashboards so they don't do the goofy centering.

Once eui updates, we can do it in a proper way with props.

@snide snide requested a review from nreese July 23, 2018 23:46
@snide snide added Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. Feature:Dashboard Dashboard related features labels Jul 23, 2018
@elasticmachine
Copy link
Contributor

💔 Build Failed

nreese
nreese approved these changes Jul 24, 2018
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
code review, verified changes to dashboard listing page in chrome and firefox

@nreese
Copy link
Contributor

nreese commented Jul 24, 2018

jenkins, test this

@elasticmachine
Copy link
Contributor

💔 Build Failed

@snide
Copy link
Contributor Author

snide commented Jul 24, 2018

jenkins test this

@elasticmachine
Copy link
Contributor

💔 Build Failed

@snide snide force-pushed the dashboard_list_no_center branch from c46d4db to c6eda91 Compare July 24, 2018 05:08
@snide
Copy link
Contributor Author

snide commented Jul 24, 2018

Rebased against master for the ML fix. Hopefully that'll allow tests to pass.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@snide snide merged commit 3bc65f1 into elastic:master Jul 24, 2018
@snide snide deleted the dashboard_list_no_center branch July 24, 2018 15:44
@snide snide mentioned this pull request Jul 24, 2018
Merged
snide added a commit to snide/kibana that referenced this pull request Jul 24, 2018
@snide
Fix centered dashboard listing (elastic#21119)
706967d
snide added a commit that referenced this pull request Jul 26, 2018
@snide
Fix centered dashboard listing (#21119) (#21157)
307a5e9
@snide snide mentioned this pull request Jul 30, 2018
Merged
snide added a commit to snide/kibana that referenced this pull request Jul 30, 2018
@snide
Fix centered dashboard listing (elastic#21119)
3751dca
snide added a commit that referenced this pull request Jul 31, 2018
@snide
[6.4] Fix centered dashboard listing (#21119) (#21427)
8af2540 
* Fix centered dashboard listing (#21119)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nreese nreese nreese approved these changes

Assignees
No one assigned
Labels
Feature:Dashboard Dashboard related features Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@snide @elasticmachine @nreese